Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessKit Visible Alt Text: Fix empty captions on GIFs without alt text #1688

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

marcustyphoon
Copy link
Collaborator

Description

Simple enough.

This skips processing image elements with alt attributes that are actually empty strings, treating them the same way we do images without the attribute at all. This fixes empty caption elements being added below GIFs without alt text.

Resolves #1687.

Testing steps

@marcustyphoon marcustyphoon added the bugfix Restores intended behavior label Jan 5, 2025
@AprilSylph AprilSylph merged commit bd3c7fa into AprilSylph:master Jan 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Restores intended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccessKit Visible Alt Text: Empty captions on GIFs without alt text
2 participants